Skip to content

CIP-0137 | Fix mini-protocols and update implementation plan #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

CIP-0137 | Fix mini-protocols and update implementation plan #1047

merged 3 commits into from
Jul 8, 2025

Conversation

@jpraynaud
Copy link
Contributor

@jpraynaud jpraynaud commented Jul 1, 2025 •
edited
Loading

This PR includes updates of the CIP-0137:

  • Some typos have been fixed in the N2C Local Message Notification mini-protocol.
  • Missing KES Period in the message has been added.
  • The Implementation plan has been updated to reflect the achieved milestones.

(latest version of updated document)

@jpraynaud jpraynaud mentioned this pull request Jul 1, 2025
Closed
rphair
rphair approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintenance and especially for expanding Path to Active... looking forward to other nodes besides the Haskell node being added someday.

FYI there has been another use case for CIP-0137 suggested in the meantime, for dApps & wallets to arrange composed and/or peer-to-peer transactions:

@rphair rphair added Update Adds content or significantly reworks an existing proposal State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. Category: Network Proposals belonging to the `Network` category. labels Jul 1, 2025
@rphair rphair requested review from Crypto2099, Ryun1 and perturbing July 1, 2025 15:07
@rphair
Copy link
Collaborator

rphair commented Jul 7, 2025

@jpraynaud please update us here in the next 24 hours about whether or not you expect further commits in this round of changes. This will help us determine if it's OK to merge this as the CIP meeting tomorrow: https://hackmd.io/@cip-editors/115

@jpraynaud
Copy link
Contributor Author

jpraynaud commented Jul 8, 2025

@jpraynaud please update us here in the next 24 hours about whether or not you expect further commits in this round of changes. This will help us determine if it's OK to merge this as the CIP meeting tomorrow: https://hackmd.io/@cip-editors/115

Hi @rphair, there is no other modification in this round of changes.
It's OK to attempt merging it at the next CIP meeting 👍

Ryun1
Ryun1 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the commitment to maintenance on this proposal
thank you @jpraynaud 💪

@rphair
Copy link
Collaborator

rphair commented Jul 8, 2025

OK then, merging in advance of meeting because of the authority this is coming from.

@rphair rphair removed the State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. label Jul 8, 2025
@rphair rphair merged commit 8b32ead into cardano-foundation:master Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rphair rphair rphair approved these changes

@Ryun1 Ryun1 Ryun1 approved these changes

@Crypto2099 Crypto2099 Awaiting requested review from Crypto2099

@perturbing perturbing Awaiting requested review from perturbing

Assignees

No one assigned

Labels

Category: Network Proposals belonging to the `Network` category. Update Adds content or significantly reworks an existing proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpraynaud @rphair @Ryun1